search

nukeop / react-ui-cards

Ready to use card components for React (rewritten in Typescript)
https://nukeop.github.io/react-ui-cards/
MIT License
237 stars 62 forks source link

added support for disabled button in product card #56

Closed RiteshKSingh1709 closed 2 years ago

RiteshKSingh1709 commented 2 years ago

Active Button UI -

image

Disabled Button UI -

image

Issue link -> #28

RiteshKSingh1709 commented 2 years ago

@nukeop Could you please review the PR.

nukeop commented 2 years ago

Can you improve the contrast on the button while it's disabled? Maybe make the background paler while keeping the text white?

RiteshKSingh1709 commented 2 years ago

@nukeop updated the UI, also while doing i realized the background-color , color should be like props to user to provide more flexibility. what i might think for any UI components along with component user needs styling flexibility. If you think the same, i can take that up in next subsequent PR.

RiteshKSingh1709 commented 2 years ago

@nukeop also you can add "hackoctoberfest" topic to this repository to attract many other collaborators. https://hacktoberfest.com/participation/#pr-mr-details