search

nukeop / react-ui-cards

Ready to use card components for React (rewritten in Typescript)
https://nukeop.github.io/react-ui-cards/
MIT License
237 stars 62 forks source link

Update Sass package. Update Storybook to version 7. #66

Closed alex-polic closed 1 year ago

alex-polic commented 1 year ago

Updated package dependency from "node-sass" to "sass" since "node-sass" has security issues.

Updated Storybook major version to be compliant with Node LTS version. Links to issues explaining the problem:

Storybook maintainer approved bump in version. Storybook migration guide (official): https://chromatic-ui.notion.site/Storybook-7-migration-guide-dbf41fa347304eb2a5e9c69b34503937

Webpack version updated to v5.

Package ready to be used with Node LTS.

nukeop commented 1 year ago

Thanks for contributing. Why is the package-lock diff so huge?

alex-polic commented 1 year ago

3 core packages had a major version update (webpack, webpack-cli and storybook), and more than a half devDependencies (mostly storybook addons) as well. Package-lock is updated to represent that change. I checked diff locally before commiting, only dependencies with new versions are updated.

alex-polic commented 1 year ago

@nukeop do you have any updates regarding timeline for merging this?