search

nukeykt / NBlood

Reverse-engineered ports of Build games using EDuke32 engine technology and development principles (NBlood/Rednukem/PCExhumed)
621 stars 78 forks source link

[Blood] Voxels break in 4K #688

Open tmyqlfpir opened 1 year ago

tmyqlfpir commented 1 year ago

When using the Blood Voxel Pack for E3M1, the sign will appear noticeably darker when viewed from a distance depending on the viewport resolution.

I have provided three screenshots of 640x480, 1600x900 and 3840x2160 all at the same position, yet the voxel is noticeably brighter for 640x480

640x480

1600x900

3840x2160

tmyqlfpir commented 1 year ago

I can confirm this same bug occurs in the original DOS executable, and has somehow continued to exist through to eduke32. This is caused by the globalvisibility changing scale to compensate for resolution. Ideally this should be tweaked so voxels use their own visibility variable that is static and not resolution dependent.

tmyqlfpir commented 1 year ago

This has been fixed upstream

tmyqlfpir commented 10 months ago

This apparently has not been fixed yet. https://github.com/clipmove/NotBlood/issues/87

Hendricks266 commented 10 months ago

It is fixed in Classic but not yet in Polymost, where it will require implementation of indexed model skins that use the lookup tables.

tmyqlfpir commented 10 months ago

Confirmed, this is only an issue with polymost currently.