make struct ym3438_t opaque

nukeykt / Nuked-OPN2

Cycle-accurate Yamaha YM3438(YM2612) emulator

GNU Lesser General Public License v2.1

214 stars 15 forks source link

make struct ym3438_t opaque #3

Closed loki666 closed 6 years ago

loki666 commented 6 years ago

mmh constructor/destructor function might be needed then, since client wont be allowed to create the ym3438_t type anymore

nukeykt commented 6 years ago

Sorry. This change breaks compatiblity with the Genesis Plus GX and requires a lot of code tweaks to fix it.

loki666 commented 6 years ago

really? it's just a matter of using the constructor / destructor it's also a more elegant way of solving issue #1 and a general rule of thumb when designing an API. what if someone come with another issue with a clash from a macro preprocessor like Qt does ?