search

nukomeet / coworfing

Find the best places to work.
http://coworfing.com
Other
31 stars 22 forks source link

Missing deps for tests #330

Closed spk closed 10 years ago

spk commented 10 years ago

Hello, The build is failing just because some missing deps. See https://travis-ci.org/nukomeet/coworfing/builds/15668358

AdrienGiboire commented 10 years ago

Actually, @zaiste removed some of them some time ago. See here https://github.com/nukomeet/coworfing/commit/7ae26da7d53f38a64cff277d9b170d8551f637bf#diff-1.

I don't remember the reason very well but I guess it was to fix some bugs. I don't know, I didn't noticed and I don't remember we were told of such things.

Also, the build fails because of tests. You might consider removing them for now as they are not up to date. At. All.

Or you can write and fix the tests to cover the app :D Your call!

spk commented 10 years ago

Yes now it's failling because of failing tests not missing deps. The last travis build is using my patch (https://travis-ci.org/nukomeet/coworfing/builds/18682022) I will watch what i can do.

pysio commented 10 years ago

Can one of the admins verify this patch?

spk commented 10 years ago

This has been fixed by 9f93f462e91c1ad1c78c768915601d267ef511e0