search

nukulb / s3-angular-file-upload

Example of S3 file upload using ng-file-upload, angular, nodejs
MIT License
135 stars 34 forks source link

Mock File object during tests to be compatible with FormData#append #10

Closed onetom closed 10 years ago

onetom commented 10 years ago

Not completely sure why, but probably because of browser version difference, the tests failed for us. (Tried with Chrome v36.0.1985.125 & Firefox 30.0) We found that plain JavaScript objects are not accepted by the append method of the FormData "class". Since we suspect it's impossible to manually create new File objects, we faked it with a new Blob extended with a name property to mimic the File interface.

nukulb commented 10 years ago

Thank you very much for the changes. I will investigate the issue in a day or two and get back to you.

nukulb commented 10 years ago

Thanks for the changes.

1) The bucket name issue is simply a miss on my end, so thanks for the changes.

2) The append issue is more interesting, I get why its not working now but I will have to go back and track what changed that caused this to actually break. I suspect a version issue with browser is the likely culprit but could easily be angular-file-upload version. When I find the issue, I will be sure to let you know.

onetom commented 10 years ago

We tried with the latest (v1.6.5) angular-file-upload too, but this form issue was still present. After applying this fix, something else broke, which we deferred fixing for now. Thanks for the merge; it's a great reference project!

nukulb commented 10 years ago

@onetom can you explain what you are referring to when you say something else broke?

nukulb commented 10 years ago

I think you might referring to the abort method being undefined in the frontend tests. I just submitted a change that will take care of that as well

see https://github.com/nukulb/s3-angular-file-upload/commit/4eda3f22edacf1e6eda7e21ef01f9a99dc8dce63