search

nul800sebastiaan / Cultiv.Tabify

MIT License
8 stars 4 forks source link

"Content" dropdown still active, confuses some users because it doesn't work #12

Closed MarcStoecker closed 4 years ago

MarcStoecker commented 5 years ago

The dropdown with the (former) sections is still showing but not switching the tabs. image

This is confusing users IMHO as they expect the tabs to switch if they click on a item in this menu?

The dropdown can be hidden with a simple CSS selector. So far I haven't seen any negative side effects.

Hendy commented 5 years ago

Hi, this works great for the regular view, but in narrow view, the page sections are rendered as a child of another button: TabsNarowViewError

MarcStoecker commented 5 years ago

Ouch. So much for the QA. 😬 I'll have a look, thanks!

MarcStoecker commented 5 years ago

Hey @Hendy, thanks for reporting this. I can't seem to reproduce it with my test instance on 8.1.5. image

Could you maybe post exact steps or windows sizes and browser or such? No idea right now ... 😕🤔

craigs100 commented 4 years ago

Hi,

The native V8 "Content" Conte(n||x)t App tab is still visible with package V1.04 and Umb V8.3.0. Looking at the package source, this section no longer works:-

/* hide the "Content" dropdown (avoid confusion) */
.dropdown-menu.umb-sub-views-nav-item__anchor_dropdown.ng-scope {
    display:none;
}

I can't see a way of targeting it either or I'd have put a PR in. Hopefully someone can ;)

skttl commented 4 years ago

Try removing the .ng-scope part from the selector

nul800sebastiaan commented 4 years ago

I don't have this problem in 8.3.0.. not sure what I'm doing differently?

12

nul800sebastiaan commented 4 years ago

Is this still a problem in v1.0.5 on Umbraco 8.3.0? I removed the .ng-scope part like @skttl suggested. Didn't make a difference for me as this already worked for me but it might help for others?

nul800sebastiaan commented 4 years ago

Thanks for reporting this! I have just retired this package since there's something better out there! 👍

Mister Søren Kottal has made many improvements on this package and it's time for me to retire this one! 🎉 If this is still an issue then make sure to head over to https://github.com/skttl/our-umbraco-matryoshka instead.