search

nul800sebastiaan / Cultiv.Tabify

MIT License
8 stars 4 forks source link

#5 Fixes validation indicator on tab labels. #8

Closed enkelmedia closed 5 years ago

enkelmedia commented 5 years ago

I've fixed the error indicator by using a "version" of the valtab-directive from the core, the current version in the core is not in a working state but this one is.

This solution will show the errors after the form has been submitted, this is done by using the css-class .show-validation which is a class that gets set on the form by the core.

nul800sebastiaan commented 5 years ago

@enkelmedia Sorry for the delay on your PRs, all looks awesome! I've been on a little holiday and I'm trying to get back on track soon. Thanks for your patience for now!

nul800sebastiaan commented 5 years ago

Fantastic, many thanks!

In the future: make sure to always switch back to master, make your changes in a clean fork, right now you mixed up PR 7 and 8, I fixed it now but it's a bit easier to review if each PR is actually separate ;-)