search

nul800sebastiaan / Cultiv.Tabify

MIT License
8 stars 4 forks source link

#7 sticky tabs #9

Closed enkelmedia closed 5 years ago

enkelmedia commented 5 years ago

This make the tabs sticky.

I just wanted to explain the "fake-top-background"-div, since the whole container scrolls the properties on the tab would be hidden by the tab-bar but then be visible over the gray background over the tab-bar. So this little "hack" hides the properties when scrolling above the tabs.

nul800sebastiaan commented 5 years ago

Sweet @enkelmedia !

It has a small problem with the Grid where the reorder block will position itself on top of the tabs, but let's fix that later!

image

ronaldbarendse commented 5 years ago

The current styles hide the top part of the scrollbar (besides visually, also an accessibility issue). As the default margin of .umb-pane is 20px and most scrollbars are less in width, that should be a good clearance to add...

The tabs list would need a container to be able to add this margin, so some work will be required to fix this.