search

nulastudio / NetBeauty2

Move a .NET Framework/.NET Core app runtime components and dependencies into a sub-directory and make it beauty.
MIT License
419 stars 21 forks source link

Application fails to run if PublishTrimmed=True #13

Closed sitiom closed 3 years ago

sitiom commented 3 years ago

Minimal reproduction: https://github.com/nulastudio/NetCoreBeauty/issues/10#issuecomment-671730525 with latest NetCoreBeauty version and PublishTrimmed set to true.

liesauer commented 3 years ago

it works for me. more details? logs, sdk version or anything.

image

sitiom commented 3 years ago

Strange, exact thing doesn't work for me.

SDK Version: 5.0.100 Built with dotnet publish -r win-x64 --self-contained true -p:PublishTrimmed=True

liesauer commented 3 years ago

looks like it's the sdk issue. the 5.0.100 sdk over-trims something and makes the app crashed(verified, still fails to run even though i disable NetCoreBeauty).

From: sitiom Date: 2020-12-24 09:22 To: nulastudio/NetCoreBeauty CC: L!εsAμεr; Comment Subject: Re: [nulastudio/NetCoreBeauty] Application fails to run if PublishTrimmed=True (#13) Strange, exact thing doesn't work for me. SDK Version: 5.0.100 Built with dotnet publish -r win-x64 --self-contained true -p:PublishTrimmed=True — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

liesauer commented 3 years ago

see dotnet/sdk#14261

sitiom commented 3 years ago

That works for now, thanks.

redthing1 commented 3 years ago

@sitiom What's the fix?

liesauer commented 3 years ago

@sitiom What's the fix?

see this comment, https://github.com/dotnet/sdk/issues/14261#issuecomment-734446135