nulib / arch

Northwestern University institutional repository, built on Samvera's Hyrax gem.
2 stars 0 forks source link

upgrade arch to sufia 7.3 #160

Closed davidschober closed 7 years ago

davidschober commented 7 years ago

done looks like

davidschober commented 7 years ago

@nulib/repodev verify the checklist. Also, can we tag any issues we think might get fixed so @cpd3149 knows to verify and close? I started a couple.

adamjarling commented 7 years ago

@davidschober @bmquinn @kdid I'll pull down the 7.3 branch and try rebasing my commits from this week. If anything weird pops up, I'll let you know on Monday.

chrisdaaz commented 7 years ago

currently testing. it seems to be working, overall, but there's a weird span element

class="state state-deposited"

displaying between the Title and Abstract: https://nufiaweb-s.library.northwestern.edu/concern/generic_works/sq87bt648

image

this appears on new works since the upgrade: https://nufiaweb-s.library.northwestern.edu/concern/generic_works/x346d4190 https://nufiaweb-s.library.northwestern.edu/concern/generic_works/xk81jk36q

also, can someone else test the "Batch Create" function? i keep trying to add multiple files through this method, but i keep getting the "!" notification saying i haven't added files.

image

i don't know if this related to the upgrade. everything else looks good to me!

kdid commented 7 years ago

Yes, batch upload not working. Looking into it.

kdid commented 7 years ago

Here is an issue related to "deposited" showing.

https://github.com/projecthydra/sufia/issues/3107

kdid commented 7 years ago

@cpd3149 - https://github.com/nulib/institutional-repository/issues/177 fixes batch uploads and is deployed to staging to test. We had overidden some code in Sufia views that changed with the upgrade.

The (!) validation on adding files or descriptions appears to be an issue with Sufia and not specific to us. Note that it is a cosmetic issue (batch still works) so let us know if this is something that is holding up on your signing off pushing the upgrade to production.

chrisdaaz commented 7 years ago

okay, cool, i've signed off -- thanks @kdid & @bmquinn !

chrisdaaz commented 7 years ago

@adamjarling @kdid if this moves to prod, will the new fonts and CSS changes move with it? i want to run the css changes by marketing.

kdid commented 7 years ago

@cpd3149 - yes, they would. So just let us know when you get the OK.

adamjarling commented 7 years ago

@cpd3149 Please note the style updates are not complete by any means. Merely a starting point. I estimated with @davidschober there's about 3-5 solid days of work to get it fully presentable.

kdid commented 7 years ago

upgraded on production