Deal with all handle/ark/link issues

mbklein commented 4 years ago

[ ] Display https URLs in all share/embed sheets
[ ] ~Make sure new works are generating arks~
[ ] ~Generate arks for all existing works~
[ ] ~Redirect existing handles to arks (batch SQL update via @d-venckus)~
[ ] Verify all works have media. style permalinks (straight to AVR)
[ ] Update links in existing course reserves w/Kurt

davidschober commented 4 years ago

I removed it from the chores epic as that's for this release. Per MBK/DS slack pointed at around 8ish.

davidschober commented 3 years ago

@mbklein let's handle this during the spin down. I'd like to get this off our plate.

mbklein commented 3 years ago

@davidschober I did some investigating on this today because I wanted to refresh my memory. I thought it was going to be pretty easy, but unfortunately, not so much.

We haven't been generating ARKs for new works in AVR since the Terraform cutover in June 2018. I don't remember why.
~Media Objects in Avalon have a single Permalink, not one per Section, so I don't know how we would support deep-linking using ARKs.~

Generating ARKs for Media Objects and replacing the URLs in the handle server with those ARKs is reasonably straightforward. ~But that last part is going to be a chore, unless we either alter the MasterFile class to support a Permalink attribute of its own or store section-level ARKs separately. But either of those options would require AVR code changes, not just configuration changes.~

EDIT: Never mind. The MasterFile model has a field for permalinks. We can do this.

davidschober commented 3 years ago

If it only supports one per section why would we deep link using arks. I’m confused by that last part.

Sent from my iPhone

On Mar 23, 2021, at 11:17 PM, Michael B. Klein @.***> wrote:

@davidschoberhttps://urldefense.com/v3/__https://github.com/davidschober__;!!Dq0X2DkFhyF93HkjWTBQKhk!CL9sqGZt-G4T6w55YMexpAL0UAlyWvhvVbOZB7yLlfe-vpBNxNzWvyWIGTbQju7B6pj4n2X7Ng$ I did some investigating on this today because I wanted to refresh my memory. I thought it was going to be pretty easy, but unfortunately, not so much.

We haven't been generating ARKs for new works in AVR since the Terraform cutover in June 2018. I don't remember why.
Media Objects in Avalon have a single Permalink, not one per Section, so I don't know how we would support deep-linking using ARKs.

Generating ARKs for Media Objects and replacing the URLs in the handle server with those ARKs is reasonably straightforward. But that last part is going to be a chore, unless we either alter the MasterFile class to support a Permalink attribute of its own or store section-level ARKs separately. But either of those options would require AVR code changes, not just configuration changes.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/nulib/avalon/issues/447*issuecomment-805474600__;Iw!!Dq0X2DkFhyF93HkjWTBQKhk!CL9sqGZt-G4T6w55YMexpAL0UAlyWvhvVbOZB7yLlfe-vpBNxNzWvyWIGTbQju7B6piT-KzQog$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ABEUVHV35K7AYLXRNPOYZ3DTFFRTJANCNFSM4IUBA5RQ__;!!Dq0X2DkFhyF93HkjWTBQKhk!CL9sqGZt-G4T6w55YMexpAL0UAlyWvhvVbOZB7yLlfe-vpBNxNzWvyWIGTbQju7B6pghhpV3JA$.

davidschober commented 3 years ago

Actually now I’m really confused. Each section in Avalon has a different handle. Let’s talk through this.

Sent from my iPhone

On Mar 24, 2021, at 5:28 AM, David Schober @.***> wrote:

If it only supports one per section why would we deep link using arks. I’m confused by that last part.

Sent from my iPhone

On Mar 23, 2021, at 11:17 PM, Michael B. Klein @.***> wrote:

@davidschoberhttps://urldefense.com/v3/__https://github.com/davidschober__;!!Dq0X2DkFhyF93HkjWTBQKhk!CL9sqGZt-G4T6w55YMexpAL0UAlyWvhvVbOZB7yLlfe-vpBNxNzWvyWIGTbQju7B6pj4n2X7Ng$ I did some investigating on this today because I wanted to refresh my memory. I thought it was going to be pretty easy, but unfortunately, not so much.

We haven't been generating ARKs for new works in AVR since the Terraform cutover in June 2018. I don't remember why.
Media Objects in Avalon have a single Permalink, not one per Section, so I don't know how we would support deep-linking using ARKs.

Generating ARKs for Media Objects and replacing the URLs in the handle server with those ARKs is reasonably straightforward. But that last part is going to be a chore, unless we either alter the MasterFile class to support a Permalink attribute of its own or store section-level ARKs separately. But either of those options would require AVR code changes, not just configuration changes.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/nulib/avalon/issues/447*issuecomment-805474600__;Iw!!Dq0X2DkFhyF93HkjWTBQKhk!CL9sqGZt-G4T6w55YMexpAL0UAlyWvhvVbOZB7yLlfe-vpBNxNzWvyWIGTbQju7B6piT-KzQog$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ABEUVHV35K7AYLXRNPOYZ3DTFFRTJANCNFSM4IUBA5RQ__;!!Dq0X2DkFhyF93HkjWTBQKhk!CL9sqGZt-G4T6w55YMexpAL0UAlyWvhvVbOZB7yLlfe-vpBNxNzWvyWIGTbQju7B6pghhpV3JA$.

davidschober commented 3 years ago

Oops. I missed your edit in the wee hours. I was responding to the email notification which didn't have the edit. Disregard the above.

davidschober commented 3 years ago

@mbklein updated with the decision to not use arks or handles in AVR

davidschober commented 3 years ago

@mbklein I'm still seeing hdl. links on media.northwestern.

davidschober commented 3 years ago

Examples from course video:

https://media.northwestern.edu/media_objects/j098zb22h

kdid commented 3 years ago

@mbklein - there are two places these are exposed. One is fixed, one is not. (share link is wrong, LTI link is right). Moving back to in progress.

kdid commented 3 years ago

@davidschober - the script to update these is running. Please verify in a couple hours. (Brendan and I do not have access to see the link provided above)

davidschober commented 3 years ago

Sorry I'm still seeing hdl links in a couple of places.

davidschober commented 3 years ago

In particular "section" and "embed". Embed of course isn't critical, but I would assume it's pulling from the same places, so I'm a bit confused.

kdid commented 3 years ago

@mbklein and @davidschober - what is the status of this on production?

davidschober commented 3 years ago

I checked before leaving and it was in the same state.

On Jun 7, 2021, at 11:14 AM, Karen Shaw @.***> wrote:

@mbklein https://urldefense.com/v3/__https://github.com/mbklein__;!!Dq0X2DkFhyF93HkjWTBQKhk!GtLKULj02Sy5z_cu6-LC8yPeqhUuCkFFlLerTs4dc7daAn5Hxjii6CSrZnKw3IUyKDoMZt3lMQ$ and @davidschober https://urldefense.com/v3/__https://github.com/davidschober__;!!Dq0X2DkFhyF93HkjWTBQKhk!GtLKULj02Sy5z_cu6-LC8yPeqhUuCkFFlLerTs4dc7daAn5Hxjii6CSrZnKw3IUyKDoT-Pr3Mw$ - what is the status of this on production?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://urldefense.com/v3/__https://github.com/nulib/avalon/issues/447*issuecomment-856073984__;Iw!!Dq0X2DkFhyF93HkjWTBQKhk!GtLKULj02Sy5z_cu6-LC8yPeqhUuCkFFlLerTs4dc7daAn5Hxjii6CSrZnKw3IUyKDqqbORlFw$, or unsubscribe https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ABEUVHVRZ5EMUNHPHP6OJRLTRTV7HANCNFSM4IUBA5RQ__;!!Dq0X2DkFhyF93HkjWTBQKhk!GtLKULj02Sy5z_cu6-LC8yPeqhUuCkFFlLerTs4dc7daAn5Hxjii6CSrZnKw3IUyKDqEwc5lew$.

davidschober commented 3 years ago

verified.

nulib / avalon

Deal with all handle/ark/link issues #447