search

nulinspiratie / SilQ

Software for quantum control of donor atoms in silicon
Other
6 stars 1 forks source link

Interfaces/pcdds auto advance #250

Closed nulinspiratie closed 3 years ago

nulinspiratie commented 4 years ago

Add feature for pulses to auto-advance after fixed interval. Requires newest PCDDS image

Linked to https://github.com/nulinspiratie/Qcodes/pull/104

nulinspiratie commented 3 years ago

@maij Perhaps the label "ready for review" should be removed, as it was added in a rush. The problem here is that you may not want the entire pulse sequence to use auto_advance, but only a portion of it. In fact, I think that's the more common scenario. For this reason having a global interface parameter "auto_advance" probably isn't the right move. I think that parameter should be deleted. On the other end of the spectrum is optionally setting an attribute "auto_advance" per pulse, though this of course feels slightly hacky. I think the best solution in the end is to use the attribute "flags" of pulse sequences, which may have a key "auto_advance" This way nested pulse sequences can inherit properties from the parent pulse sequence. I believe I already implemented something like this in the 81180A AWG. We could also consider adding the attribute "flags" to the Pulse, which could also have the key "auto_advance". This way we could also set auto_advance on a pulse-by-pulse basis.

nulinspiratie commented 3 years ago

Closed because I want to start over