search

null-dev / DynamicHistory

Automagically delete browsing history based on the content of the page!
MIT License
20 stars 3 forks source link

Few feature suggestions #11

Open Kusresa opened 6 years ago

Kusresa commented 6 years ago

I am new to using your addon so far it is great. I have a few suggestions that I think could improve it:

1) Dangerous keywords not recognized when site loads content after initial page load - example Youtube. If I have a dangerous keyword that is found in the comments section it will not be applied because Youtube loads the comment section only after initial page load and after the user scrolls down the page. I read your comment in 'Known Bugs' about Dynamic titles and that a fix for it may affect performance a bit, I'm not sure if dynamic content is similar to this. I think if the user can specify to only search dynamic titles/content on specific domains/urls the performance effect won't be that much more than usual.

2) Toolbar icon to show what domain/keyword was applied on that page when hovering over it or clicking it can be useful to see which domain/keyword is affecting it (can also be useful to debug if one of the rules aren't needed but I don't know which)

3) Android support - Would be great to use this on Android. As far as I know it's not possible right now but in the future I think APIs will be coming to Android to make this possible.

Thanks!

null-dev commented 6 years ago

Responding to suggestions in order:

  1. This was an old feature that I actually removed since I didn't think it was useful anymore. I will add this back in the next release.

  2. Definitely considering this. Not sure if it will make the next release however.

  3. The extension should already work on Firefox Android (although last time I tried it, I couldn't find a way to access the options page). If Chrome ever adds the ability to install extensions on mobile, DynamicHistory should work without any problems.

Kusresa commented 6 years ago
  1. I thought it will install on Firefox for Android but wouldn't actually work because the history permission isn't yet available for Android (according https://developer.mozilla.org/en-US/Add-ons/WebExtensions/Differences_between_desktop_and_Android). I may be wrong though about the permissions required for the addon, I will see if it is working with Android.

Another feature I just thought about is deleting previous history using the dangerous domains/keywords. So something like a button when clicked (with user warning of course) it will delete all history that matches the user's domains/keywords rules (in case the addon missed cleaning some pages for whatever reason or user doesn't want to manually clean previous history after adding new domains/keywords).

null-dev commented 6 years ago

Oh, my bad, didn't realize that some APIs are not implemented on Android yet...

I can't match keywords when wiping old history (because that would involve downloading all the webpages stored in the history to get their text content) but I can match domains. I'll look into this.

null-dev commented 6 years ago

Feature requests 1 and 2 have now been implemented in the latest extension version (v2.7).

The fix for feature request 1 has to be manually enabled in the options section as it's off by default. It's the option called 'Enable continuous matching' and may affect performance if enabled.

null-dev commented 6 years ago

Oops, closed it by mistake. I'm leaving this issue open until the Android version can be used.

Kusresa commented 6 years ago

Great work, can confirm feature 1 and 2 work well!

I noticed for feature 2 that when clicking the icon to see what domains/keywords were applied on page it only shows the first matched, is it possible to show all keywords that were matched on the page? Also one thing could the matched domains/keywords be given a bold red color? Not a big thing just makes it a little easier to differentiate the matches from other text :)

null-dev commented 6 years ago

I would like to avoid showing all matched keywords since it actually incurs a performance penalty.

The extension only shows the first match because as soon as it finds the first keyword, it knows the page is "dangerous". It doesn't need to try finding the rest of the keywords (saving it time). I will consider having it only match all the keywords while the popup is open but that is quite a bit of extra work so I'll leave it for later.

As for bolding the keyword, do you mean bolding the keyword on the page or in the popup?

Kusresa commented 6 years ago

Oh, I thought that might have been the reason why it only showed the first matched keyword, that's fine then.

For bolding I meant the keyword in the popup

TimLinton commented 10 months ago

A feature that would be really nice is password protecting the keyword lists.