search

null-dev / firefox-profile-switcher

Create, manage and switch between browser profiles seamlessly.
GNU General Public License v3.0
377 stars 26 forks source link

Keyboard shortcut support #1

Closed null-dev closed 2 years ago

cupcakearmy commented 2 years ago

Yes please! Maybe Ctrl + Shift + M / Cmd + Shift + M to be consistent with chrome?

fazlerabbi37 commented 2 years ago

anyone working on this? If not, I would like to take a jab at it :sweat_smile:

null-dev commented 2 years ago

anyone working on this? If not, I would like to take a jab at it sweat_smile

I'm currently not working on this as I'm still trying to stabilize profile switching (still isn't perfect yet). If you would like to work on this though, I'd recommend using https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/commands as it lets users customize the shortcuts without having to write your own UI to do that.

fazlerabbi37 commented 2 years ago

cool! I will get started :ok_hand:

I'd recommend using https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/commands

thanks a ton for the pointer! :pray:

fazlerabbi37 commented 2 years ago

PR for this issue: #19

cupcakearmy commented 2 years ago

PR for this issue: #19

Amazing ❤️ Is there a reason you did not choose the default key mappings of chrome?

fazlerabbi37 commented 2 years ago

Is there a reason you did not choose the default key mappings of chrome?

actually, yes. while I would have liked that too but the default key mappings of chrome (Ctrl+Shit+m) opens Responsive Design Mode on Firefox. :cry:

cupcakearmy commented 2 years ago

Ah ok, I'm on macOS so it's different here. Makes sense :)

null-dev commented 2 years ago

Fixed in newest release!