search

null-dev / firefox-profile-switcher

Create, manage and switch between browser profiles seamlessly.
GNU General Public License v3.0
377 stars 26 forks source link

Set last focused Window as Default Profile #104

Open Invertex opened 10 months ago

Invertex commented 10 months ago

Whenever window focus changes, the Default Profile will be set to whatever the new window is. This will then ensure external links you click will open in your last focused window instead of the pre-set Default Profile.

A lot of people coming from Chrome complain about this missing in Firefox, and Firefox used to have this behaviour. It's a lot better for usability.

I dunno if something extra needs to be done to add the function, I don't know anything about the Svelte stuff, I just tested with the extension unpacked.

Invertex commented 10 months ago

It might be good to add a checkbox in the options to disable this behavior, but it should probably be on by default in my opinion.

Invertex commented 10 months ago

I really like the idea of adding this to this add-on. I'm not remotely an expert in this code base, but I'd love to see this merged, so I've left some suggestions. The biggest thing is that this probably won't get accepted without a having it be an option in the settings. Since it changes the behavior current users are used to, it will probably have to be disabled by default to maintain consistency.

I would normally agree, but I feel like in this situation it's probably more ideal for the long-term for this to be the default? My assumption would be most people using something like this would want this behaviour, and those that don't will notice the change and look for the options. It's not a highly impactful change to now make default and puts the burden of thinking to look for options on a smaller percentage of users, I feel.

But yeah I was wanting to leave adding the option up to the original dev so they could do it properly with this toolchain instead of hacked in through inference. But maybe I should bite the bullet and look at figuring out the toolchain.

jakawell commented 10 months ago

Mostly, I just don't think they'll merge this PR with it changing default behavior, but I could be wrong.

LTSCommerce commented 7 months ago

This issue is causing me pain, not quite enough to mess about installing FF developer edition at the moment

I very much hope this PR gets merged ASAP. If there's blocking reasons, then hopefully they can be raised with Invertex and solved so that this can be merged and FF can be a real Chrome alternative for people who use profiles.

People who don't use profiles - wow, you are missing out

Invertex commented 7 months ago

Unfortunately it seems like they completely abandoned this project. I tried emailing them as well and no response.

marmotz commented 5 months ago

Unfortunately it seems like they completely abandoned this project. I tried emailing them as well and no response.

If this project is abandoned, can you fork it and release a new addon?

Invertex commented 2 months ago

I'll see if I can publish a properly working branch at some point.. but really I'd just recommend people switch to Floorp. It's a branch of Firefox that has this whole feature built-in already, and many other improvements.