[bug] Koharu from Keiyoushi not using default reading mode

[mangkoran]

Steps to reproduce

1. Set "Settings -> Reader -> Default reading mode" to "Right to left"
2. Install Koharu extension from Keiyoushi
3. Open any manga from it

Expected behavior

Any manga opened should use Yokai's default reading mode.

Actual behavior

Any manga opened will use "Left to right" and ignore Yokai's default reading mode.

Crash logs

-

Yōkai version

1.8.4.3

Android version

14

Device

Redmi Turbo 3

Other details

I'm not sure whether this is Yokai's bug or extension's bug, but I found no reference to reading in the extension repo. However, this only happens with Koharu. Other sources are using the default just fine. I also have checked using Mihon and it's not an issue in Mihon.

Please let me know if you need more details regarding this issue.

Acknowledgements

• [X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
• [X] I have written a short but informative title.
• [X] If this is an issue with an extension, or a request for an extension, I should be contacting the extensions repository's maintainer/support for help.
• [X] I am reporting an issue exclusive to this fork. I have also checked that is not an issue on the main version of Mihon
• [X] I have tried the troubleshooting guide.
• [X] I have updated the app to version 1.8.4.3.
• [X] I have updated all installed extensions.
• [X] I have filled out all of the requested information in this form.

[null2264]

It's a J2K behaviour where it overwrite the Reading mode from default to Long Strip if it's a manhwa or LTR if it's a manhua/comic. No way to disable it at the moment (not sure why it wasn't an option tbh).

You can change it to Default by clicking "Use Default" btw.

[mangkoran]

@null2264 well yes I could click "Use Default" but well this is still a bug :)

In the meanwhile, we can leave this issue open to track this.

Anyway, thank you for your work with this fork!

[null2264]

well yes I could click "Use Default" but well this is still a bug

Not exactly a bug, Koharu probably use Manhua or Comic tag for all their entries. The only workaround I could think of is to give an option to disable the "smart reading mode" feature entirely.

[mangkoran]

Oh wait then this could be considered as extension bug? If so I will open an issue in Keiyoushi

[null2264]

Nah, it's probably Koharu behaviour... sources can be weird sometimes

[mangkoran]

~I mean, if it can be overridden extension side, it could be a workaround. Most Koharu content is manga anyways.~

Sorry, I just remember this is J2K feature so there is no relation to extension right?

[null2264]

J2K feature so there is no relation to extension right?

Yep, it detects the tag "english" so it automatically use LTR

[mangkoran]

Just quick scanning through the repo. I suppose these are the tags used to detect comic type?

https://github.com/null2264/yokai/blob/91656140e5f5ceefdf1424d08663e2a893d2e524/app/src/main/java/eu/kanade/tachiyomi/data/database/models/Manga.kt#L249-L251

[null2264]

Yes, also here

https://github.com/null2264/yokai/blob/91656140e5f5ceefdf1424d08663e2a893d2e524/app/src/main/java/eu/kanade/tachiyomi/data/database/models/Manga.kt#L209-L217

[mangkoran]

The manga above is indeed have tag "english" on it. How if we remove tag.startsWith("english") in above lines? I'm not sure if this is a good condition/filter for comic type (the filter was last updated 3 years ago btw). We do have more manga content than comic anyway.

If so, I'm happy to open PR.

[null2264]

I don't mind personally, feel free to open a PR.

[sandesh-404]

The same is true for me with manganato extension.

[null2264]

Not really a bug, but I guess might as well remove LTR auto detection since it seems to cause too many confusion...

UPDATE: I decided to re-enable the feature, but only triggered when it detects "comic".