null2264 / yokai

Free and open source manga reader for Android
Apache License 2.0
759 stars 18 forks source link

For Local source to detect manga from both internal and external storage, not just one #197

Open lalalasupa0 opened 2 months ago

lalalasupa0 commented 2 months ago

Describe your suggested feature

In short, I want my local source to load manga from both my internal and external storage at the same time

Other details

Currently only one can be chosen, meaning that my local source won't load the manga in one of the two storages, and I would have to move the manga from one to another, but the space in this storage could be full, and that's where the problem arises

Acknowledgements

null2264 commented 1 month ago

Not sure tbh, one of the benefit of one "Storage location" was because some custom rom (especially CN phones and Smasnug) sometime did something that caused the app to lose write access to it (especially for SDCard), so user only have to deal with 1 location to fix. I could probably make the app read from /sdcard/Android/data/<yokai package id>/local/, since that location is pretty much free, tho the path is a bit long.

lalalasupa0 commented 1 month ago

Not sure tbh, one of the benefit of one "Storage location" was because some custom rom (especially CN phones and Smasnug) sometime did something that caused the app to lose write access to it (especially for SDCard), so user only have to deal with 1 location to fix. I could probably make the app read from /sdcard/Android/data/<yokai package id>/local/, since that location is pretty much free, tho the path is a bit long.

Tbf the path you mentioned seems fine to me, what matters, at least to me, is that it detects the manga in my internal and external memory at the same time