null2264 / yokai

Free and open source manga reader for Android
Apache License 2.0
370 stars 7 forks source link

Asura bug that's specific to j2k and yokai #40

Closed sofari23 closed 4 months ago

sofari23 commented 4 months ago

Steps to reproduce

  1. Open Asura
  2. Add something to your library
  3. After a while the title added to your library doesn't show it's in your library when you are browsing

Expected behavior

Titles addes to your library should be marked as so when browsing.

Actual behavior

Titles in your library aren't marked that they are in their library when browsing and migrating doesn't fix it.

Crash logs

No response

Yōkai version

1.7.14

Android version

Android 14

Device

Redmi note 12

Other details

It's not an extension issue since mihon and tachiyomi SY don't have this problem

Acknowledgements

null2264 commented 4 months ago

Is permanent url disabled? AFAIK, the only way for it to do that is if perma url is disabled...

sofari23 commented 4 months ago

Permanent url is enabled

On Mon, Feb 19, 2024, 10:41 AM Ahmad Ansori Palembani < @.***> wrote:

Is permanent url disabled? The only way for it to do that is if perma url is disabled...

— Reply to this email directly, view it on GitHub https://github.com/null2264/yokai/issues/40#issuecomment-1951867111, or unsubscribe https://github.com/notifications/unsubscribe-auth/BEN3WZ7TZBE7VURIPFBUGZLYUL6Z7AVCNFSM6AAAAABDOJWPGKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJRHA3DOMJRGE . You are receiving this because you authored the thread.Message ID: @.***>

null2264 commented 4 months ago

I can't replicate it unfortunately...

sofari23 commented 4 months ago

It's alright i understand

On Mon, Feb 19, 2024, 2:22 PM Ahmad Ansori Palembani < @.***> wrote:

I can't replicate it unfortunately...

— Reply to this email directly, view it on GitHub https://github.com/null2264/yokai/issues/40#issuecomment-1952240939, or unsubscribe https://github.com/notifications/unsubscribe-auth/BEN3WZY4DGLCESMIBZGYECDYUMYWBAVCNFSM6AAAAABDOJWPGKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJSGI2DAOJTHE . You are receiving this because you authored the thread.Message ID: @.***>

Xeiv commented 4 months ago

I have the same issue with Asura and permanent url is enabled

sofari23 commented 4 months ago

For some reason j2k doesn't want to fix it and since yokai is forked from j2k, it will never be fixed

ImpenetrableNoble commented 4 months ago

@sofari23 Well I plan on ordering a laptop soon for college purposes since I have to attend to class actively but when I graduate in 2025 then I'll start fork j2k's Tachiyomi version and make it, I thought about other projects in mind as well but it's mostly for business purposes on GitHub. For now being patient is what matters to me for the future.

null2264 commented 4 months ago

For some reason j2k doesn't want to fix it and since yokai is forked from j2k, it will never be fixed

Not really it's already (partially) fixed (GH-2) in Yokai. I just couldn't figure out how to replicate this issue.

sofari23 commented 4 months ago

For some reason j2k doesn't want to fix it and since yokai is forked from j2k, it will never be fixed

Not really it's already (partially) fixed (GH-2) in Yokai. I just couldn't figure out how to replicate this issue.

You can replicate it by adding a bunch of series from Asura to your library and after one day some of them won't be marked to be in your library when browsing

null2264 commented 4 months ago

I pushed some potential fixes, you can test it on Nightly version.

sofari23 commented 4 months ago

I pushed some potential fixes, you can test it on Nightly version.

Alright let me test it. I will get back to you

sofari23 commented 4 months ago

I pushed some potential fixes, you can test it on Nightly version.

I tried it and i think it's fixed. Thank you

Xeiv commented 4 months ago

Thank you, it seems to be working for me too

null2264 commented 4 months ago

Okay, thanks for testing... I'll mark this as complete, you can reopen it if the issue comes back.