null2264 / yokai

Free and open source manga reader for Android
Apache License 2.0
637 stars 12 forks source link

Issue with split tall images. #41

Closed Dinor closed 4 months ago

Dinor commented 7 months ago

Steps to reproduce

  1. Enable split tall images
  2. Download the chapter

Expected behavior

Images are downloaded and split

Actual behavior

Error: Couldn't Split Downloaded image

Crash logs

No response

Yōkai version

1.7.14

Android version

Android 8.1

Device

Xiaomi Mi Pad

Other details

It works without any issues on TachiyomiSY and Mihon, however, in Yokai and TachiyomiJ2K there's an error. Is the method to split tall images different in Yokai and J2K compared to SY and Mihon?

Acknowledgements

null2264 commented 4 months ago

Seems to be false positive, it's checking if it should split the image, but for some reason Jay send notification that the image can't be split even tho in reality it's "This image is fine, I should not split this".

The difference between SY and J2K (or YK) is that SY didn't notify the user that it couldn't (shouldn't) split the image.