null2264 / yokai

Free and open source manga reader for Android
Apache License 2.0
370 stars 7 forks source link

App forcibly closes every time I delete or move an entry in my library #51

Open lalalasupa0 opened 3 months ago

lalalasupa0 commented 3 months ago

Steps to reproduce

Delete or move an entry

Expected behavior

It does it, but...

Actual behavior

... The app is forcefully closed at the same time

Crash logs

The app doesn't give me one

Yōkai version

1.7.14

Android version

Android 12

Device

Samsung 10+

Other details

Might be an issue of my device, however, It is not a heating or battery optimization problem

Acknowledgements

lalalasupa0 commented 1 month ago

Screenshot_20240529_161220_Ykai yokai_crash_logs.txt Screenshot and crash log

null2264 commented 1 month ago

Seems to caused by outdated database handler, can't be fixed until I modernized the database handler.

null2264 commented 3 weeks ago

Probably fixed by https://github.com/null2264/yokai/commit/b17578365d292d6d32f4dba9968859539eba02ad, or at least partially... (You can test it on Nightly r5174 or newer)

null2264 commented 2 weeks ago

Screenshot_20240529_161220_Ykai yokai_crash_logs.txt Screenshot and crash log

This crash is definitely fixed, but I detected other similar crash.

lalalasupa0 commented 1 week ago

@null2264 It started crashing in this r5373 update while reading

Screenshot_20240625_152448_Ykai Nightly yokai_crash_logs.txt

null2264 commented 1 week ago

That's compose stuff, can't fix it, Google need to fix it unfortunately.

lalalasupa0 commented 1 week ago

That's compose stuff, can't fix it, Google need to fix it unfortunately.

When you say Google has to fix it, it dashes my hopes You believe it could fix itself in future updates?

I also saw a lot of stuff regarding that compose thing in a google search, and this started happening with the new Yokai update only, maybe there is something in it idk

It's happening a loooooot, really, a looooooooooooot

null2264 commented 1 week ago

Interesting, I'll try upgrading compose to newest snapshot and see if that helps, they did say they fixed it, but hasn't release it

null2264 commented 6 days ago

That's compose stuff, can't fix it, Google need to fix it unfortunately.

When you say Google has to fix it, it dashes my hopes You believe it could fix itself in future updates?

I also saw a lot of stuff regarding that compose thing in a google search, and this started happening with the new Yokai update only, maybe there is something in it idk

It's happening a loooooot, really, a looooooooooooot

That has been resolved by Google on new beta release (https://github.com/null2264/yokai/commit/2471f454f8fd5e32014893cb9b8c38eb71060016)

REF: https://developer.android.com/jetpack/androidx/releases/compose-ui#1.7.0-beta04

lalalasupa0 commented 6 days ago

Interesting, I'll try upgrading compose to newest snapshot and see if that helps, they did say they fixed it, but hasn't release it

It seems that it was fixed with that update (im not completely sure), I forgot to confirm it at the moment

null2264 commented 6 days ago

Oh, nice.