Cannot 'save' pages from different chapters if they have the same name

lalalasupa0 commented 4 months ago

Steps to reproduce

Save one page of both chapters with the same name

Expected behavior

Both should just appear in gallery

Actual behavior

One overwrites the other

Crash logs

No response

Yōkai version

1.8.1.2-b5126

Android version

Android 12

Device

Samsung S10+

Other details

If the page number is different this does not happen

I suppose it would be better to say that it might be better if it were possible to save the same page twice, then the second one should have a "_(1)" added to it to act as a copy, this way so as not to overwrite the other one

I believe other forks do that, Mihon too I think

This wouldn't necessarily be good as an absolute, since it's not inconvenient in other sources when you want to reorder saved pages and so forth. But I think it would be nice if we could select whether to overwrite the previous page or copy it (from settings, of course)

Using the Nighly Build

Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
[X] I have written a short but informative title.
[X] If this is an issue with an extension, or a request for an extension, I should be contacting the extensions repository's maintainer/support for help.
[X] I am reporting an issue exclusive to this fork. I have also checked that is not an issue on the main version of Mihon
[X] I have tried the troubleshooting guide.
[X] I have updated the app to version 1.8.1.2.
[X] I have updated all installed extensions.
[ ] I have admitted that I am a clown by having checked this box, as I have not read these acknowledgements.
[X] I have filled out all of the requested information in this form.

lalalasupa0 commented 4 months ago

@null2264 It is still there (overwriting the previous page with the same name in gallery) Or is there an option to enable for it to take effect? The new one in "Downloads" is already activated and it's still like this

Nightly Build 5130

null2264 commented 4 months ago

Looks like I forgot to push one change, my internet being dumb right now so I'll have to wait for it to stabilise...

null2264 commented 4 months ago

It went back to normal as soon I sent that, I just pushed the missing change

lalalasupa0 commented 4 months ago

It went back to normal as soon I sent that, I just pushed the missing change

Now it's works fine👍🏻

null2264 commented 4 months ago

Lovely.

null2264 / yokai