search

null2264 / yokai

Free and open source manga reader for Android
Apache License 2.0
362 stars 7 forks source link

Added some new simple but versatile functions #85

Closed AshbornXS closed 3 weeks ago

AshbornXS commented 3 weeks ago

got all functions from TachiyomiS97 so all credits go to Saud-97, in my opinion they are some pretty good functions to have even thought pretty simple, if liked feel free to use

AshbornXS commented 3 weeks ago

oops discart the updates to readme, idk how to remove it

null2264 commented 3 weeks ago

Idk about "long tap browse source to uninstall", I think the browse list shouldn't be used to manage extensions (the feature already exists on extensions bottom sheet anyway), and "auto fetch chapters on browse" seems like an unnecessary load for the source.

For the rest of them I think it's fine. Although I'm still debating about long tap on recents and browser nav, that could potentially disturbing someone's muscle memory.

AshbornXS commented 3 weeks ago

that makes sense, "auto fetch chapters on browse" is a toggle so by default isn't a load, it is by option, and for the long tap maybe put a toggle to enable/disable them? I think at least the recents one is pretty cool

null2264 commented 3 weeks ago

Yeah, I'm not comfortable of adding toggle for "auto fetch chapters on browse"... But I could add the long tap nav as an option.

null2264 commented 3 weeks ago

Merged as https://github.com/null2264/yokai/commit/b4638017dd774d9dcd325258611f663083493015