null2264 / yokai

Free and open source manga reader for Android
Apache License 2.0
362 stars 7 forks source link

Add Music #86

Closed Fuzzythegoatq closed 2 weeks ago

Fuzzythegoatq commented 3 weeks ago

Describe your suggested feature

Add the music thing when you're reading Manhwas on Legal sites they have a music thing. I'd like that feature. (Webtoons)

Other details

No response

Acknowledgements

AshbornXS commented 3 weeks ago

just put on some music yourself lmao

Fuzzythegoatq commented 3 weeks ago

just put on some music yourself lmao

I need that anime music custom made😤 Like Manhwas

SSL-ACTX commented 2 weeks ago

Wow, what a useless feature request. 💀

Achyuth072 commented 2 weeks ago

Well it's not really a useless feature, as the webtoon app has custom music which changes based on the segment, yes music changes in a single chapter too. I honestly don't how one would implement this, this was denied back in Tachiyomi and sitting in dust in other forks as feature requests like this. Well your best bet would if ever auto scroll is implemented like maybe the music can be synced with that. Either way its a huge undertaking. But I'm all up for it.

AshbornXS commented 2 weeks ago

I don't think it's even possible to implement something like that, would probably be necessary to add a lot of things that would impact app performance, auto scroll is already on the backlog but I don't think that music feature would be something considered on future versions

if you want the music badly, sadly maybe it's just better to read directly from the website

Achyuth072 commented 2 weeks ago

Honestly yes, the last thing anyone wants is performance dips. The reader apps for me has some hitches when I read long form content already this would just be another pain. Well the best OP could do is rip the custom music hope it syncs with their scrolling.

AshbornXS commented 2 weeks ago

yeah, and other thing, maybe I'm wrong but I think that to add something like that would basically need an rework on both the app and the extensions, so even if the option is added on Yōkai maybe it won't be possible to use bcz the extensions doesn't support it

Achyuth072 commented 2 weeks ago

yeah, and other thing, maybe I'm wrong but I think that to add something like that would basically need an rework on both the app and the extensions, so even if the option is added on Yōkai maybe it won't be possible to use bcz the extensions doesn't support it

No you're completely right, I think rather working on the Yokai its best work on the Webtoons extensions itself since that's the source with custom music. Reworking the whole app for custom music for very few titles would not be efficient.

Well I guess OP has to take this to that extension's creator see what they say.

null2264 commented 2 weeks ago

It is possible to inject my own function to support BGM to certain exts, J2K has SY's delegated source feature, but I'm not sure if I want to jump to audio player rabbit hole... It's probably less painful than video player, but I don't think it's worth it tbh... I haven't even used Webtoon ext for years.