search

null8626 / python-weather

A free and asynchronous weather API wrapper made in python, for python.
https://python-weather.rtfd.io
MIT License
100 stars 31 forks source link

Weather Info Source #57

Closed davidearlyoung closed 4 months ago

davidearlyoung commented 4 months ago

Hello,

This is just a friendly suggestion based on my experience. I want to suggest that it would be smart to let people know where you are sourcing weather details for this project to work.

I was frustrated in having to dig into your code in order to find out that your using wttr.in. Which in turn uses WMO (World Meteorological Organization) and NWS (National Weather Service) from what I'm hearing.

Reason this is important is that I live in a place where it's harder to predict accurate weather. And different weather organizations do better with their predictions then others. Not having this detail upfront would be one strong reason for me to walk away from using your project.

Adjustments could be something simple as putting a line or two in the main README for this projects repo.

I hope that this helps. Thanks for taking time to read this.

null8626 commented 4 months ago

Hai! Thank you so much for this. Will do!

null8626 commented 4 months ago

After looking at wttr.in's source, it seems that the project uses World Weather Online though, as noted from this function.

davidearlyoung commented 4 months ago

Ah, Interesting. I saw something else in a different file. I'll see if I can dig that up in case that is useful for you. Thanks for looking into this.

davidearlyoung commented 4 months ago

Also, just as a side note, here is where I found that your lib used wttr.in:

See: python-weather/python_weather/client.py (line 87).

https://github.com/null8626/python-weather/blob/3b5f8fe31733643fe840b37159d4a8e43a043d57/python_weather/client.py#L87)

Which I believe is your current for your main branch for that file.

I'm curious now where I saw that it was WMO and not WWO for my source of info. If I find it and it seems useful or helpful, I likely share that info.

davidearlyoung commented 4 months ago

Ok, so it looks like it came from an online search that was assisted by Ai. I had missed that it was Ai assisted.

Interesting note. Even with cited sources that were used by the Ai to gen a search result, the Ai still hallucinated the details of the WMO and NWS.

I was already aware this common problem with Ai assisted generation. But it still got me in a area I didn't expect it. My bad.

Regardless, I do appreciate that you took the time to validate your and chubin's weather info source. Overall a good win. And I can see that you have now listed weather info source on your Readme.

I'm good with the situation related to this issue.

You have yourself a excellent day! And thanks for your time.