nulldriver / cf-cli-resource

Cloud Foundry CLI Concourse Resource
Apache License 2.0
45 stars 55 forks source link

set-env should support multiple environment variables #71

Closed patrickcrocker closed 4 years ago

patrickcrocker commented 4 years ago

Instead of this:

  - put: cloud-foundry
    params:
      commands:
      - command: set-env
        app_name: myapp-ui
        env_var_name: SOME_KEY
        env_var_value: SOME_VALUE
      - command: set-env
        app_name: myapp-ui
        env_var_name: SOME_OTHER_KEY
        env_var_value: SOME_OTHER_VALUE

let's support this:

  - put: cloud-foundry
    params:
      commands:
      - command: set-env
        app_name: myapp-ui
        environment_variables:
          SOME_KEY: SOME_VALUE
          SOME_OTHER_KEY: SOME_OTHER_VALUE

This is also consistent with how env vars are passed to zero-downtime-push (and soon push as well).

patrickcrocker commented 4 years ago

Implemented in v2.18.0