search

nulldriver / maven-resource

Maven Repository Manager Concourse Resource
Apache License 2.0
21 stars 49 forks source link

Incorrect SNAPSHOT version checking logic for `in` script. #12

Closed shinmyung0 closed 6 years ago

shinmyung0 commented 6 years ago

I noticed that the implicit get after a put for my snapshot artifacts were breaking. I did some digging and the reason was that the implicit get step was looking for the snapshot version artifacts from the release_url. This is due to a typo in the in script for checking whether a version is a snapshot version.

in script uses an && https://github.com/patrickcrocker/maven-resource/blob/master/assets/in#L89

out script uses an || which is the correct behavior. https://github.com/patrickcrocker/maven-resource/blob/master/assets/out#L106

I fixed my pipeline scripts to use 1.3.2 instead of latest for now. Thanks again for your great work!

patrickcrocker commented 6 years ago

This is now fixed and the 1.3.3 release has been yanked. Thanks!

See: https://github.com/Pivotal-Field-Engineering/maven-resource/releases/tag/v1.3.4