nulldriver / maven-resource

Maven Repository Manager Concourse Resource
Apache License 2.0
21 stars 49 forks source link

Require image for ARM64 architecture #38

Open odidev opened 3 years ago

odidev commented 3 years ago

Hi Team,

I am trying to use the maven-resource image on arm64 platform but it seems it is not available for arm64.

I have successfully built the image using the command docker build -t image_name . on the arm64 platform without any changes in the Dockerfile.

Do you have any plans on releasing arm64 images?

I am curious on how the amd64 image is getting published on Dockerhub as I am not able to access the current CI build

It will be very helpful if the image is released with ARM64 support. If required, I am happy to contribute.

patrickcrocker commented 3 years ago

Very interesting, this is the first request I've seen about arm64 support. I didn't know that Concourse even supports arm64 workers (I don't see any arm64 binaries available on the Concourse releases page).

Can you share how you are using arm64 workers on Concourse?

I'd imagine that the best way to support this would be to provide another version of the maven-resource docker image that uses something like the arm64v8/openjdk Docker image. In that case, you'd specify the architecture in the version of the resource config:

resource_types:
- name: maven-resource
  type: registry-image
  source:
    repository: nulldriver/maven-resource
    tag: latest-arm64

Of course, I don't currently have an arm64 based worker in my Concourse environment for testing. Again, I'd want to understand how to add an arm64 based worker to my CI environment so I can properly test this.

Please let me know your thoughts.

odidev commented 3 years ago

I have built the image for arm64 on my arm64 local machine. As you have mentioned that you are using concourse and arm64 binary is not available for concourse, even I was unable to build and test image for arm64 on concourse.

It seems it is a little complex to add arm64 builds in concourse until an official release is provided. So, I have tried another solution for this issue which is to use Travis CI just for arm64 builds. I built the image using Travis-ci and pushed it to Dockerhub.

Commit Link - https://github.com/pheobe07/maven-resource/commit/6367f7dda80cf20e6da5738740222e185dced020

Travis Link - https://travis-ci.com/github/pheobe07/maven-resource/builds/212670278

Docker Hub Link - https://hub.docker.com/r/odidev/maven-resource/tags?page=1&ordering=last_updated

Can you please suggest your opinions on this? If required I will raise a PR.