nulli0n / ExcellentCrates-spigot

GNU General Public License v3.0
42 stars 63 forks source link

Custom Items Not Stacking With Each Other #229

Open SiuanSong opened 1 month ago

SiuanSong commented 1 month ago

Purpur v1.21.1 #2326 ExcellentCrates v5.3.3 Nightcore v2.6.4

I am having an odd issue that I've never encountered on this plugin before. Sometimes when opening keys, I receive items that are supposed to be identical, but do not stack. Even when they are won within minutes (or seconds) of each other.

I ran /paper dumpitem on three of these (supposed to be) identical items. For some reason, the id modifier is different on all three items given by the crate. These are the beginning of the item dumps, I'll include the full ones in a pastebin as they're kinda long, but this is the only difference I see:

minecraft:tnt[attribute_modifiers={modifiers: [{amount: 0.25d, id: "minecraft:ec3a3969-a18b-48e4-879e-690e568ab3ed", minecraft:tnt[attribute_modifiers={modifiers: [{amount: 0.25d, id: "minecraft:afda1f0e-1636-48b2-b935-08b928fcce49", minecraft:tnt[attribute_modifiers={modifiers: [{amount: 0.25d, id: "minecraft:0e5ce6a5-60dd-4df7-a735-35f52c15d290",

Full /paper dumpitems for those three mentioned above: https://pastebin.com/UHfqLmCa

javaw_jbIpFesGfA javaw_i5jRONexQw javaw_6tuTrlxrxA

Here's the opening.log showing the four clock heads shown in the last image so you can see the timestamps.

[19/10/2024 02:59:55] Siuan won Grandfather Clock (ID: 15, Weight: 3.0) from Cursedcrate2024 Crate (ID: cursedcrate2024) [19/10/2024 02:59:56] Siuan won Grandfather Clock (ID: 15, Weight: 3.0) from Cursedcrate2024 Crate (ID: cursedcrate2024) [19/10/2024 02:59:56] Siuan won Grandfather Clock (ID: 15, Weight: 3.0) from Cursedcrate2024 Crate (ID: cursedcrate2024) [19/10/2024 03:00:23] Siuan won Grandfather Clock (ID: 15, Weight: 3.0) from Cursedcrate2024 Crate (ID: cursedcrate2024)

This has happened with multiple items over the course of the last two months (since we updated to 1.21.1)

Please let me know if you need any more information. Thank you! :)

nulli0n commented 1 month ago

Unable to reproduce on Paper 1.21.1-123 Send full config of that crate please

SiuanSong commented 1 month ago

Unable to reproduce on Paper 1.21.1-123 Send full config of that crate please

https://gist.github.com/SiuanSong/59f1e469a028beed196c03e6a86e5ddf

nulli0n commented 2 weeks ago

Perhaps there is some plugin that modifies your items? Like IllegalStack or something? I'm still unable to reproduce it using your crate config. With a few plugins reload, I always get similar items. изображение

nulli0n commented 2 weeks ago

Also try disable Data_Fixer in nightcore's config if it's enabled.