nullpo-head / WSL-Hello-sudo

Let's sudo by face recognition of Windows Hello on Windows Subsystem for Linux (WSL). It runs on both WSL 1 and WSL 2. This is a PAM module for Linux on WSL.
MIT License
1.22k stars 46 forks source link

fix: quote hello_winpath in uninstall.sh #28

Closed jonaskuske closed 2 years ago

jonaskuske commented 2 years ago

Just noticed that the path to the Windows install directory isn't quoted in the uninstall.sh file. Because of this, the directory isn't removed on uninstall if the path contains spaces. Worse, since the path is treated as two separate ones (before and after the space), the uninstall script might rm -rf other, unrelated directories¹ – so I'd say this is quite an urgent fix!


¹ if the users Tim and Tim Scott exist, uninstall.sh runs rm -rf /c/Users/Tim Scott/pam_wsl_hello and boom, say goodbye to Tim's home directory!

nullpo-head commented 2 years ago

Thanks for the catch!