search

nullpunkt / lz-string-php

PHP Class implementation of LZ-String javascript
105 stars 54 forks source link

Feature: Add support for PHP 8; Change phpunit to 9.5 #24

Closed jchodzicki closed 3 years ago

dducro commented 3 years ago

Please merge this PR

jchodzicki commented 3 years ago

Hey, I have no write access :(

wt., 15 cze 2021 o 20:31 Daniël Ducro @.***> napisał(a):

Please merge this PR

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nullpunkt/lz-string-php/pull/24#issuecomment-861737391, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACW4CDUU36HX6ZOPXND324DTS6L7TANCNFSM434A6KGQ .

nullpunkt commented 3 years ago

Hey! Thank you for the upgrade. Did you check if your fix also works with PHP Versions <=7 ? There should be at least support for PHP 6 and 7.

dducro commented 3 years ago

I confirm this version works om 7.3 and 7.4

jchodzicki commented 3 years ago

Hey! Thank you for the upgrade. Did you check if your fix also works with PHP Versions <=7 ? There should be at least support for PHP 6 and 7.

https://www.php.net/supported-versions.php This will be working on supported versions.