Closed bruce-fs closed 7 years ago
You are adding new methods to the API so you should give Funky users the best experience you can.
The more verbose the doc, the smaller the need to wonder what exactly a "Page username" is.
On Tue, Jan 24, 2017 at 4:14 PM, Bruce notifications@github.com wrote:
@bruce-fs commented on this pull request.
In lib/funky/page.rb https://github.com/Fullscreen/funky/pull/73:
@@ -0,0 +1,43 @@ +module Funky
- class Page < FacebookGraphRootNode
For further detailed documentation, see
https://developers.facebook.com/docs/graph-api/reference/page/
@return [String] the name of the Facebook Page.
@claudiofullscreen https://github.com/claudiofullscreen - updated... curious, why is the code review for the documentation style changing now? I was following the original style this was done in....
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Fullscreen/funky/pull/73, or mute the thread https://github.com/notifications/unsubscribe-auth/AHEL02-iUJG9hLijUkjpoxmtd9PqoKqoks5rVpPrgaJpZM4Ls6Tf .
--
Claudio Baccigalupo | Manager, Software Engineering | Fullscreen, Inc. http://www.fullscreen.com
@claudiofullscreen
Coverage remained the same at 100.0% when pulling b66e3016dd42ccc16c73ebbd304b8d583201db92 on add-page into cdcf0f81c54dde4f260f34719552e50ab5fef9e4 on master.