nullscreen / fb-video

Funky is a Ruby library to fetch data about videos posted on Facebook.
MIT License
7 stars 6 forks source link

Add API for fetching facebook page data #73

Closed bruce-fs closed 7 years ago

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling b66e3016dd42ccc16c73ebbd304b8d583201db92 on add-page into cdcf0f81c54dde4f260f34719552e50ab5fef9e4 on master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling e3d8893acb4570a93dc493f6f0d6ed6912f0bd4e on add-page into cdcf0f81c54dde4f260f34719552e50ab5fef9e4 on master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling cb6bd732e054c95dca411af1365be430d609ad5b on add-page into cdcf0f81c54dde4f260f34719552e50ab5fef9e4 on master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling ffc07c48e90fcc0bf26383322cd560c876ed1608 on add-page into cdcf0f81c54dde4f260f34719552e50ab5fef9e4 on master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 7ba60baff3448a59393665875efaed2b7103ef61 on add-page into cdcf0f81c54dde4f260f34719552e50ab5fef9e4 on master.

claudiofullscreen commented 7 years ago

You are adding new methods to the API so you should give Funky users the best experience you can.

The more verbose the doc, the smaller the need to wonder what exactly a "Page username" is.

On Tue, Jan 24, 2017 at 4:14 PM, Bruce notifications@github.com wrote:

@bruce-fs commented on this pull request.

In lib/funky/page.rb https://github.com/Fullscreen/funky/pull/73:

@@ -0,0 +1,43 @@ +module Funky

@claudiofullscreen https://github.com/claudiofullscreen - updated... curious, why is the code review for the documentation style changing now? I was following the original style this was done in....

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Fullscreen/funky/pull/73, or mute the thread https://github.com/notifications/unsubscribe-auth/AHEL02-iUJG9hLijUkjpoxmtd9PqoKqoks5rVpPrgaJpZM4Ls6Tf .

--

Claudio Baccigalupo | Manager, Software Engineering | Fullscreen, Inc. http://www.fullscreen.com

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 38f06dec50bc19484d1aee40d5c52d4d0b1766b1 on add-page into cdcf0f81c54dde4f260f34719552e50ab5fef9e4 on master.

bruce-fs commented 7 years ago

@claudiofullscreen

yardoc

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.3%) to 99.733% when pulling 33e8fb3e7e22462cd1b5b8c380d11911b1060543 on add-page into e3668f0c5d8dc3538fd66d68f0f0a943db405fcb on master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.3%) to 99.733% when pulling 833659c3228aedd36fbffbd044d6dd1f6fd1050a on add-page into e3668f0c5d8dc3538fd66d68f0f0a943db405fcb on master.