Add support for Ruby 3.0

nullscreen / squid

A Ruby library to plot charts in PDF files

http://nullscreen.github.io/squid/

MIT License

220 stars 42 forks source link

Add support for Ruby 3.0 #64

Closed floriandejonckheere closed 1 year ago

floriandejonckheere commented 3 years ago

Ruby 3.0 separates positional from keyword arguments, which renders some calls in the gem not to work anymore (mostly where options is used as a Hash instead of keyword arguments). Splatting the hash makes the methods work again.

coveralls commented 3 years ago

Coverage remained the same at 100.0% when pulling 0e67fbebe2012c82a64f9716c18cfe8025173630 on floriandejonckheere:ruby-3-0-0 into 08eae1d881a8324cee50d7e6bd2c6ca76779bd13 on Fullscreen:master.

timrogers commented 3 years ago

👍 @Fullscreen Is there any chance that you might be able to merge this? Squid doesn't work with Ruby 3.x without it.

rmosolgo commented 2 years ago

Thanks @floriandejonckheere, I was able to get going again by updating my gemfile to point at your branch:

gem "squid", "~> 1.4", github: "floriandejonckheere/squid", ref: "0e67fbebe2012c82a64f9716c18cfe8025173630"

justinhoward commented 1 year ago

Fixed in #68