search

nullstone-io / nullstone

Nullstone is a customizable developer platform launched on your cloud accounts.
https://nullstone.io
MIT License
39 stars 1 forks source link

263 Profiles #2

Closed BSick7 closed 3 years ago

BSick7 commented 3 years ago

This adds profile support to the Nullstone CLI. This also fixes reading the api key on windows.

BSick7 commented 3 years ago

Looks great, only change I would suggest is putting all the support for each flag in the same place. Looks like the address flag is added in cmd/configure.go while the profile flag has it's own file.

I put the profile flag in a separate file because it is global to the CLI while the address flag is specific to the configure command.

ssickles commented 3 years ago

Looks great, only change I would suggest is putting all the support for each flag in the same place. Looks like the address flag is added in cmd/configure.go while the profile flag has it's own file.

I put the profile flag in a separate file because it is global to the CLI while the address flag is specific to the configure command.

Fair enough, sounds good to me.