nulogy / design-system

Nulogy Design System
http://nulogy.design
MIT License
64 stars 13 forks source link

Fix Popper Timeout Tracking #1417

Closed jherdman closed 1 week ago

jherdman commented 1 month ago

Description

We noticed that Popper was sometimes closing the dorpdown inaccurately. This was pinned down to timeouts being incorrectly cleared, and thefore sometimes running when they ought not to. Careful examination of the code revealed that they weren't being tracked very well, and thus stomped on or lost.

This approach leverages a ref to track the value to avoid loss during re-renders, and to also avoid unnecessary re-renders.

Changes include

Feature checklist

github-actions[bot] commented 1 week ago

:tada: This PR is included in version 10.2.8 :tada:

The release is available on:

Your semantic-release bot :package::rocket: