nulogy / design-system

Nulogy Design System
http://nulogy.design
MIT License
64 stars 13 forks source link

Improve Pagination Types #1421

Closed jherdman closed 4 weeks ago

jherdman commented 1 month ago

Description

The previous iteration of these type was accounting for the generated page numbers being either a string (SEPARATOR) or numbers.

In this commit I introduce a much narrower type for the getPageItemsToDisplay function. In doing so we more closely map to the reality of the implementation and can use a more appropriately narrow type for onSelectPage.

This resolves some challenges with ECO.

Changes include

Feature checklist

github-actions[bot] commented 4 weeks ago

:tada: This PR is included in version 10.2.6 :tada:

The release is available on:

Your semantic-release bot :package::rocket: