search

num-codex / codex-processes-ap1

Business processes for the NUM CODEX project (AP1) as plugins for the HiGHmed Data Sharing Framework
Apache License 2.0
3 stars 6 forks source link

Failed validation due to ICD Codes #114

Closed jorieck closed 1 year ago

jorieck commented 1 year ago

While performing a stand alone validation, we had multiple issues with the validation of ICD Codes. For every ICD Code we were told that the validation failed without further information or any reason.

In one resource which conforms to the profile 'Stage at diagnosis' of the GECCO dataset (Link: https://simplifier.net/forschungsnetzcovid-19/diagnosiscovid19-duplicate-2) we are using both a SNOMED CT Coding and an ICD Coding: sct icd

According to the profile this is allowed: profile

However, after the validation the following error message shows up: response

After we removed the ICD Codings, the validation of the resources was successful.

Is there any explanation why the validation of ICD Codes fails?

hhund commented 1 year ago

Hi @riejo,

thank you for reporting this issue. From what I can see so far, validation of CodeableConcept elements with multiple Coding entries is not fully supported by our validator.

To be more specific, the HAPI validator we are extending is performing the validation of Codings in two steps. The Coding is first validated against the CodeSystem and then validated against the ValueSet if a binding is specified. Since we do not download the complete ICD-10 code-systems but only the ValueSet, the offline validation against the CodeSystem can not be performed, resulting in the false positive error you are reporting.

jorieck commented 1 year ago

Hello,

is there any update regarding this bug or when it can be fixed? Thanks

hhund commented 1 year ago

The implementation in #119 removes the dual code checks for CodeSystems: http://fhir.de/CodeSystem/bfarm/icd-10-gm, http://fhir.de/CodeSystem/dimdi/icd-10-gm, http://fhir.de/CodeSystem/bfarm/ops and http://fhir.de/CodeSystem/dimdi/ops, http://fhir.de/CodeSystem/ifa/pzn. Codes from these systems are only checked against there ValueSets and not against the CodeSystem. We may need to reopen this issue in the future to implement a generalized solution.