search

numToStr / FTerm.nvim

:fire: No-nonsense floating terminal plugin for neovim :fire:
MIT License
743 stars 23 forks source link

Border colours are inverted #19

Closed maxigaz closed 3 years ago

maxigaz commented 3 years ago

Update: For others joining in, I misinterpreted the issue at first. See my next comment below for describing the real problem.

With Neovim v0.5.0-dev+1302-g8a93d1028, when I run the following, the border style looks exactly the same as if single was replaced with double:

:lua require'FTerm'.setup({border = 'single'})

Adjusting this setting through an init file has the same results.

On the other hand, using the values none and shadow (taken from :h nvim_open_win) works as expected.

numToStr commented 3 years ago

IIUC then double border is not working for you. But It is working fine for me. As you can see in the image below. image

maxigaz commented 3 years ago

I'm sorry, I was mistaken. Here's how simple and double look for me, respectively:

nvim-fterm-1 nvim-fterm-2

So, the real issue is that the border and the area around it seems inverted. (I didn't notice the difference until I moved closer to the screen because of the colour contrast.)

This is how vim-floaterm looks, by the way:

nvim-fterm-3

numToStr commented 3 years ago

This looks like a highlight issue to me. I've only set Normal hi group for the floating window.

numToStr commented 3 years ago

@maxigaz Could you please try fix/border_hi branch? And let me know whether your issue is fixed or not.

maxigaz commented 3 years ago

I've just tried it and the borders are still inverted.

nvim-fterm-4

numToStr commented 3 years ago

Hmm...could you tell me your theme?

maxigaz commented 3 years ago

I'm using nvim-solarized-lua. (And the solarized variant, out of the four ones that plugin comes with.)

maxigaz commented 3 years ago

The issue is now fixed in nvim-solarized-lua.