search

numToStr / FTerm.nvim

:fire: No-nonsense floating terminal plugin for neovim :fire:
MIT License
743 stars 23 forks source link

Colour configuration #23

Closed eddyekofo94 closed 3 years ago

eddyekofo94 commented 3 years ago

I see there's no way to modify colours. I got a PR concerning the colours not showing on FTerm. my attempt to fix it locally seems to not be working.

 local filetype = vim.api.nvim_buf_get_option(0, "filetype")

  -- File/buffer specific settings
  if filetype == "FTerm"  then
    colors.black = "#fff"
    colors.bg2 = "#fff"
  end

I think the problem might be stemming from this. Any help or suggestions would be appreciated. Thanks

numToStr commented 3 years ago

Hey, I am aware of this issue. This is the same issue I faced when I was using gruvbox-material.

The reason is for this issue is that terminal colors are not set properly or overlap with the background which makes it kinda invisible.

I am maintaining my own Lua fork of gruvbox-material which has fixes for this issue. https://github.com/numToStr/gruvbox-material/blob/dbafc4f38a7a00cbfd90fead1f3cf8ba6b3a3ae6/lua/gruvbox-material/definitions.lua#L1572

This is how it looks with the patches. image

Hope this helps :)

eddyekofo94 commented 3 years ago

Thanks, now I see where I was erring, thanks :)