Closed beauwilliams closed 3 years ago
Thanks for fix. But I already tried that character but for reason It overlaps with others on my machine. Screenshot attached
Would you mind sharing the screenshot of the issue that you are having.
Odd, it might be a machine specific thing then or related to my terminal. I suspected it might be the case as your screenshot looks like how mine now looks with my fix applied.
Before fix: https://i.ibb.co/HKfpnLF/Screen-Shot-2020-12-19-at-8-35-12-pm.png
After fix: https://i.ibb.co/gMNXQCf/Screen-Shot-2020-12-19-at-8-36-34-pm.png
You can see that on my machine the after image, where I applied my fix looks just fine
Ahh, that is defintely machine/terminal specific. How about adding an option to switch between characters?
require'FTerm'.setup({
-- Something like this, Not sure about key name
fixBorder = true
})
I think that would be a decent workaround 👍
@beauwilliams Now you can customiz individual border character like this.
require'FTerm'.setup({
-- Default border characters, you can customize them individually
border = {
horizontal = '─',
vertical = '|',
topLeft = '┌',
topRight = '┐',
bottomRight = '┘',
bottomLeft = '└'
}
})
I hope this solves your issue. :)
On my system, each character on the left/right border has a small space between them, so I replaced the existing character with a character that I also use for indent lines and it solved the issue.
I see in the screenshot provided that the border on the left hand side and right hand side should be solid and not broken.
Not sure if its a difference in systems but this change fixes it on my end and now the terminal looks like it does in the provided screenshot.
Please review and if it looks good with you we can merge this fix in