numToStr / FTerm.nvim

:fire: No-nonsense floating terminal plugin for neovim :fire:
MIT License
721 stars 24 forks source link

Avoid linter complaints from missing fields in setup table #91

Open adigitoleo opened 10 months ago

adigitoleo commented 10 months ago

Hello, thanks for this wonderful implementation. I contributed previously to vim-floaterm and then used my own functions for a while, but now I'm migrating to init.lua and will adopt FTerm instead.

I have a minor grievance: I implemented a version of :Man that uses the FTerm buffer like this:

vim.api.nvim_create_user_command("MAN", function(opts)
    local arg = vim.fn.expand("<cword>")
    if opts.args ~= "" then arg = opts.args end
    require("FTerm").scratch({ cmd = { "man", arg } })
end, { nargs = "?" })

It works, however my lua linter (from the lua-language-server) is complaining about "Missing fields" in the setup table for scratch(). Do you know of a way to avoid this? Thanks

xixiaofinland commented 9 months ago

It's an issue in the current lua lang server, discussed here

You can put this above your line to disable this warning: require("FTerm").scratch({ cmd = { "man", arg } }) Not perfect but should work

---@diagnostic disable-next-line missing-fields 
tummetott commented 7 months ago

Not it’s not an issue in luals. The annotations are simply wrong, they should be marked as optional.

see https://github.com/hrsh7th/nvim-cmp/pull/1694