numagic / lumos

scalable accelerated optimal control
MIT License
16 stars 0 forks source link

improve ParameterTree handling #60

Open yunlongxu-numagic opened 2 years ago

yunlongxu-numagic commented 2 years ago

TODO:

yunlongxu-numagic commented 1 year ago

to ensure the model parameters are again set back to numpy types, we should create a test:

yunlongxu-numagic commented 1 year ago

model_params.set_param(...) modifies the parameters in the model where model_param comes from in place (probably already a dangerous behavior?! maybe should force the use of model.set_recursive_params afterwards?) model_params.replace_subtree(..) does not modify the parameters used in the model in place!