numahealth / Asknuma

0 stars 0 forks source link

Removing Hardcoded Application Resources URLs #18

Closed TundeMichael closed 7 years ago

TundeMichael commented 7 years ago

The following URLs were found to have been hardcoded on different pages.

The implication is that, when the version of the application done by Unyscape (https://www.asknuma.com/asknuma) gets decommissioned or moved to another URL, these resources will not be available anymore and the pages relying on them for functionalities will break. Also if a new developer comes on board and tries to work without internet access for the browser to download these resources, the code will also break. The fix will remove these dependencies by dynamically checking the application's root directory and attaching it to the resource location e.g replace www.asknuma.com/asknumapublic/quickadmin/images/asknuma.png with

{{ Request::root() }}/public/quickadmin/images/asknuma.png

This has to be done in all the pages where these URLs are referenced.