search

numandev1 / react-native-bottomsheet-reanimated

React Native bottom sheet with fully native 60 FPS animations and awesome user experience
MIT License
277 stars 28 forks source link

Props are not optional (typescript) #23

Closed peterjskaltsis closed 2 years ago

peterjskaltsis commented 3 years ago

Hi there,

Thanks for taking the time to put this package together. I tried using this recently in a TS project and noticed it was asking me to define all of the props.

This file... https://github.com/nomi9995/react-native-bottomsheet-reanimated/blob/master/lib/typescript/src/index.d.ts

...has the TS type and it seems like many of the props have not been made optional here. Is this intentional?

Thanks in advance

numandev1 commented 3 years ago

@peterjskaltsis thanks for letting me know. I will make optional props

numandev1 commented 2 years ago

fixed by #26