search

numandev1 / react-native-compressor

🗜️Compress Image, Video, and Audio same like Whatsapp 🚀✨
MIT License
852 stars 85 forks source link

maxSize isn't implemented for manual compression (iOS) #130

Closed closetothe closed 1 year ago

closetothe commented 1 year ago

Current behavior

The maxSize is always 1920 when the compressionMode is manual. See manualCompressionHelper inside VideoCompressor.swift – it's hardcoded to 1920

Expected behavior

maxSize is set from the given options and 1920 is used as a fallback.

Platform

React Native Version

0.68.2

React Native Compressor Version

1.6.1

Reproducible Steps And Demo

Try setting the maxSize with compressionMethod: "manual" – but there's no point in reproducing it, you can see right there in the code that it's always set to 1920

github-actions[bot] commented 1 year ago

👋 @closetothe Thanks for opening your issue here! If you find this package useful hit the star🌟!

numandev1 commented 1 year ago

released in 1.7.0