search

numandev1 / react-native-keys

🔐 Protected .ENVs variables in React Native 🚀✨
MIT License
314 stars 28 forks source link

[fix] crash in release mode (Android, proguard off) #67

Closed talaikis closed 1 year ago

talaikis commented 1 year ago

Current behavior

Working fine in debug mode, On release crashes the app upon opening without errors.

Expected behavior

Working release build.

Platform

React Native Version

0.72.6

React Native Compressor Version

-

Reproducible Steps And Demo

  1. import 'react-native-keys'
  2. Builld budnle or apk
  3. Install on physical device or emulator
  4. Open app
github-actions[bot] commented 1 year ago

👋 @talaikis Thanks for opening your issue here! If you find this package useful hit the star🌟!

numandev1 commented 1 year ago

which version, you are using for keys package, can you attach apk which is crashing?

talaikis commented 1 year ago

0.7.7-0.7.9, I'll try to make separate repro in a week, because this one is private and pretty huge. If that's conflict with some dependency, then it will take longer.

numandev1 commented 1 year ago

@talaikis can you try to remove this line and test

https://github.com/numandev1/react-native-keys/pull/66/files#diff-197b190e4a3512994d2cebed8aff5479ff88e136b8cc7a4b148ec9c3945bd65aR159

talaikis commented 1 year ago

@talaikis can you try to remove this line and test

That patch works.

numandev1 commented 1 year ago

@talaikis released in 0.7.10