search

numaproj-labs / numaplane

Apache License 2.0
1 stars 4 forks source link

Disabling auto-heal should prevent Auto-healing even if I make a commit #261

Open juliev0 opened 5 months ago

juliev0 commented 5 months ago

Describe the enhancement

Currently, if we turn off auto-healing, it won't prevent auto-healing if somebody makes a commit. Once the commit occurs, the auto-syncing does everything including auto-healing.

Scenario: If auto heal is off, I'm a user, and I manually update my Deployment resource in the cluster but then I change my ConfigMap spec in github, I want my ConfigMap to get updated but I don't want my Deployment to be auto-healed.

Edit: I just spoke to someone from ArgoCD who says the behavior actually does match our current behavior (although they also have an option of doing a Partial Sync manually I guess). So, I've listed this as an enhancement instead.

Message from the maintainers:

Impacted by this bug? Give it a 👍. We often sort issues this way to know what to prioritize.

juliev0 commented 5 months ago

@xdevxy I changed this to "enhancement" as you imagined it should be. I just spoke to someone from ArgoCD who says the behavior actually does match our current behavior (although they also have an option of doing a Partial Sync manually I guess).