search

numaproj-labs / numaplane

Apache License 2.0
1 stars 4 forks source link

Separate Module Watcher From Syncer.go #295

Open shubhamdixit863 opened 4 months ago

shubhamdixit863 commented 4 months ago

Yes (https://github.com/numaproj-labs/numaplane/issues/166)

Modifications

In this PR, I have separated the logic for checking changes in the repo for GitSync into a separate module."

Verification

Unit tests and verified in the Local cluster

shubhamdixit863 commented 4 months ago

@xdevxy and @juliev0, I tried putting the logic for this sync function as well but there are lot of depedencys . I was bit unsure whether if this is what you guys were expecting. It will be helpful if you put bit more elaboration .Thanks

xdevxy commented 4 months ago

Convert this to draft with latest priority shift.