When we return our health status to ArgoCD, we want to make sure that what we return isn't outdated. This article describes the risk. If a spec has changed but hasn't yet been reconciled, the Status may look like everything is in a good "Running" state even though it hasn't been reconciled.
We should include an ObservedGeneration field in our Status.
We should also make sure that if we're still in the process of updating our Pipeline (i.e. we're pausing the old one first and haven't yet rolled out the new one) our Phase should be "Pending" and not "Running" yet.
TODO: need to consider how to best reflect this
Use Cases
When would you use this?
Message from the maintainers:
If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.
Summary
When we return our health status to ArgoCD, we want to make sure that what we return isn't outdated. This article describes the risk. If a spec has changed but hasn't yet been reconciled, the Status may look like everything is in a good "Running" state even though it hasn't been reconciled.
We should include an ObservedGeneration field in our Status.
We should also make sure that if we're still in the process of updating our Pipeline (i.e. we're pausing the old one first and haven't yet rolled out the new one) our Phase should be "Pending" and not "Running" yet.
TODO: need to consider how to best reflect this
Use Cases
When would you use this?
Message from the maintainers:
If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.