numaproj / helm-charts

Helm charts for the Numaproj ecosystem projects.
Apache License 2.0
4 stars 3 forks source link

Fix the port configuration for insecure server #11

Closed chandankumar4 closed 6 months ago

chandankumar4 commented 6 months ago

Fixes: https://github.com/numaproj/helm-charts/issues/10

Have verified for below cases:

case 1: With setting server.configs.insecure as "true"

**installing numaflow**
$ helm install numaflow . --set server.configs.insecure="true" --namespace numaflow-system --create-namespace
NAME: numaflow
LAST DEPLOYED: Mon May 20 23:12:46 2024
NAMESPACE: numaflow-system
STATUS: deployed
REVISION: 1
TEST SUITE: None
NOTES:
1. Get the application URL by running these commands:
  export POD_NAME=$(kubectl get pods --namespace numaflow-system -l "app.kubernetes.io/name=numaflow-ux" -o jsonpath="{.items[0].metadata.name}")
  export CONTAINER_PORT=$(kubectl get pod --namespace numaflow-system $POD_NAME -o jsonpath="{.spec.containers[0].ports[0].containerPort}")
  kubectl --namespace numaflow-system port-forward $POD_NAME $CONTAINER_PORT
  echo "Visit http://127.0.0.1:$CONTAINER_PORT to use your application"

**Configmap info:**
 $ kubectl get cm -n numaflow-system numaflow-cmd-params-config -o yaml
apiVersion: v1
data:
....
  server.disable.auth: "true"
  server.insecure: "true"
  server.port: "8080"
  server.readonly: "false"
kind: ConfigMap
metadata:
...

**numaflow-server deployment info**
$ kubectl get deploy numaflow-server -n numaflow-system -o yaml
.....
 livenessProbe:
          failureThreshold: 3
          httpGet:
            path: /livez
            port: 8080
            scheme: HTTP
          initialDelaySeconds: 3
          periodSeconds: 3
          successThreshold: 1
          timeoutSeconds: 1
        name: main
        ports:
        - containerPort: 8080
          protocol: TCP
.....

Case 2: With setting server.configs.insecure as "false"

$ helm install numaflow .  --namespace numaflow-system --create-namespace
NAME: numaflow
LAST DEPLOYED: Mon May 20 23:19:54 2024
NAMESPACE: numaflow-system
STATUS: deployed
REVISION: 1
TEST SUITE: None
NOTES:
1. Get the application URL by running these commands:
  export POD_NAME=$(kubectl get pods --namespace numaflow-system -l "app.kubernetes.io/name=numaflow-ux" -o jsonpath="{.items[0].metadata.name}")
  export CONTAINER_PORT=$(kubectl get pod --namespace numaflow-system $POD_NAME -o jsonpath="{.spec.containers[0].ports[0].containerPort}")
  kubectl --namespace numaflow-system port-forward $POD_NAME $CONTAINER_PORT
  echo "Visit http://127.0.0.1:$CONTAINER_PORT to use your application"

**Configmap info:**
$ kubectl get cm -n numaflow-system numaflow-cmd-params-config -o yaml
.....
  server.insecure: "false"
  server.port: "8443"
  server.readonly: "false"
.....

**numaflow-server deployment info**
$ kubectl get cm -n numaflow-system numaflow-cmd-params-config -o yaml
....
livenessProbe:
          failureThreshold: 3
          httpGet:
            path: /livez
            port: 8443
            scheme: HTTPS
          initialDelaySeconds: 3
          periodSeconds: 3
          successThreshold: 1
          timeoutSeconds: 1
        name: main
        ports:
        - containerPort: 8443
          protocol: TCP
.....